CRV MultiRewarder Contract #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elliot <[email protected]>
Signed-off-by: Elliot <[email protected]>
Signed-off-by: Elliot <[email protected]>
Signed-off-by: Elliot <[email protected]>
CRV MultiRewarder Contract
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
Signed-off-by: Elliot <[email protected]>
Signed-off-by: Elliot <[email protected]>
Signed-off-by: Elliot <[email protected]>
Signed-off-by: Elliot <[email protected]>
Signed-off-by: Elliot <[email protected]>
…rred into staking contract Signed-off-by: Elliot <[email protected]>
|
We can back the tests and compiler run out of CI once we are satisfied with things to decrease CI times. |
ElliotFriedman
commented
Mar 4, 2025
| @@ -30,6 +30,10 @@ runs: | |||
| run: forge compile --contracts proposals/ | |||
| shell: bash | |||
|
|
|||
| - name: Compile MultiRewarder | |||
| run: forge compile --contracts crv-rewards/ | |||
| shell: bash | |||
There was a problem hiding this comment.
will be deleted once we pass audit
ElliotFriedman
commented
Mar 4, 2025
| retry_wait_seconds: 60 | ||
| timeout_minutes: 20 | ||
| max_attempts: 3 | ||
| command: time forge test --match-path test/unit/MultiRewards.t.sol -vvv |
There was a problem hiding this comment.
this as well as the tests will be deleted once audit clears
…ining this design decision Signed-off-by: Elliot <[email protected]>
Signed-off-by: Elliot <[email protected]>
…onwell-contracts-v2 into feat/curve-multi-rewarder
|
anajuliabit
reviewed
Mar 5, 2025
|
|
||
| // ------------------------------------------------------------------------------------------------------ | ||
| // ------------------------------------------------------------------------------------------------------ | ||
| // Simple testing utilities since forge-std minimum solidity version is 0.6.20 and MultiRewards is 0.5.17 |
anajuliabit
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CRV MultiRewarder Contract for incentivizing Metamorpho Vault Deposits
Forked from https://github.com/curvefi/multi-rewards/blob/master/contracts/MultiRewards.sol
Diff, should only be formatting changes: https://www.diffchecker.com/nA6Jb3Md/